This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bitfield-- != 0 transformation in fold-const.c


Kazu Hirata <kazu@cs.umass.edu> writes:

| Hi Roger,
| 
| > My apologies, I pulled the test case straight from the bugzilla PR
| > without consideration for "small" targets.  I think its safe to
| > either just completely remove the ubyte field from the sdata struct,
| > i.e. for all platforms, or to pad it to a short using "ubyte:8;".
| > The PR concerns overflow in a single bit field and isn't affected
| > by this later structure padding.
| 
| OK.
| 
| > Consider such a patch pre-approved for mainline.  At the risk of
| > over stepping my authority, I also think its extremely safe to also
| > fix this testcase on the 3.4 and 3.3 branches.  Mark?  Gaby?
| 
| To backport my patch to 3.4 and 3.3, I opened a new PR 14544.

OK for GCC-3.3.4.

Thanks,

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]