This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH for java.nio FileChannel and MappedByteBuffer


>>>>> "Andreas" == andreas tobler <toa@pop.agri.ch> writes:

>> +#if defined(__JV_POSIX_H__) && defined(HAVE_MMAP)

I don't like the header guard #define being used as a test macro.

Andreas> extern int munmap(void *, size_t);
Andreas> extern int msync(void *, size_t, int);

Andreas> extern int munmap(caddr_t, size_t);
Andreas> extern int msync(caddr_t, size_t, int);

Usually our fix in situations like this is to introduce a new
template function to work around the platform differences.  See,
e.g., getpwuid_adaptor in java/lang/natRuntime.cc.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]