This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix testsuite iconv discovery
On Mon, 2004-03-08 at 14:19, Alexandre Oliva wrote:
> On Mar 8, 2004, Eric Christopher <echristo@redhat.com> wrote:
>
> > On Mon, 2004-03-08 at 13:29, Alexandre Oliva wrote:
> >> On Mar 3, 2004, Eric Christopher <echristo@redhat.com> wrote:
> >>
> >> > * Makefile.in: Export LIBICONV when testing.
> >>
> >> Wouldn't it be better to set it in site.exp, instead of passing it
> >> through the environment?
>
> > Since we already get the value for the Makefile from configure why not
> > use it there?
>
> Err... I meant the site.exp that the Makefile itself creates:
>
Um... no reason in particular I guess - other than I hadn't seen that.
> site.exp: ./config.status Makefile
> @echo "Making a new config file..."
> [...]
>
> Sorry that I wasn't clear.
s'ok. :)
*reworks patch*
-eric
--
Eric Christopher <echristo@redhat.com>