This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR middle-end/14289: TREE_STATIC global reg vars



Is this version OK? This mostly makes the middle-end more robust,
so perhaps additional front-end patches should also be investigated.


The mental model we should have is that the front end passes the middle end only either (a) valid code, or (b) code with error_mark_node in the obvious places.

Obviously, criterion (b) is not optimially precise...

Your patch is OK for 3.4. However, I think that for the mainline, we should try to arrange things so that the bogus register declaration results in the thing not being put in a register at all. We should issue an error at the point of declaration if at all possible, and then unset DECL_REGISTER on the variable, or make its type error_mark_node, or some such.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]