This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] patch for PR13708 for 3.4 and the mainline
- From: Michael Koch <konqueror at gmx dot de>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: java-patches at gcc dot gnu dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 1 Mar 2004 07:39:57 +0100
- Subject: Re: [PING] patch for PR13708 for 3.4 and the mainline
- References: <62A3CA89-6B24-11D8-888A-000393A6D2F2@physics.uc.edu>
Am Montag, 1. März 2004 03:01 schrieb Andrew Pinski:
> http://gcc.gnu.org/ml/gcc-patches/2004-01/msg03355.html
> Do not use getClass but link to the selected class.
! String c_encoding = canonicalize (encoding);
! if (c_encoding.equals("8859_1")) return new Output_8859_1 ();
! if (c_encoding.equals("ASCII")) return new Output_ASCII ();
! if (c_encoding.equals("EUCJIS")) return new Output_EUCJIS ();
! if (c_encoding.equals("JavaSrc")) return new Output_JavaSrc ();
! if (c_encoding.equals("SJIS")) return new Output_SJIS ();
! if (c_encoding.equals("UTF8")) return new Output_UTF8 ();
! if (c_encoding.equals("iconv")) return new Output_iconv
(c_encoding);
! return new Output_iconv (encoding);
I wonder if this is correct or sufficient. Shouldnt "ASCII" be called
"US-ASCII", "8859_1" should probably be "ISO-8859-1", "UTF8" should be
"UTF-8". "UTF-16", "UTF-16BE" and "UTF-16LE" is totally missing.
I think we should at least put all the default JVM encodings here.
Michael