This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR 14203: Use DECL_RTL_SET_P in uninitialized_vars_warning

From: Mark Mitchell <mark at codesourcery dot com>
To: Roger Sayle <roger at eyesopen dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sun, 29 Feb 2004 00:29:04 -0800
Subject: Re: [PATCH] PR 14203: Use DECL_RTL_SET_P in uninitialized_vars_warning
Organization: CodeSourcery, LLC
References: <Pine.LNX.4.44.0402281202390.20726-100000@www.eyesopen.com>

Roger Sayle wrote:

Hi Mark,

Alas I'd bootstrapped and regression tested the following fix for
PR middle-end/14203 before I noticed that you'd recently assigned
this PR to yourself.  Is this the fix you're investigating?

The problem is that uninitialized_vars_warning is using DECL_RTL to
check whether a declaration has RTL, instead of DECL_RTL_SET_P.
The former has the unfortunate side-effect of actually attempting to
generate RTL, which then leads to an ICE.  My guess is that this is
unintentional in a routine intended to issue compiler warnings.

The following patch has been tested on i686-pc-linux-gnu with a full
"make bootstrap", all languages except treelang, and regression tested
with a top-level "make -k check" with no new failures.

Ok for mainline and 3.4?

Yes, thanks.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

References:
- [PATCH] PR 14203: Use DECL_RTL_SET_P in uninitialized_vars_warning
  - From: Roger Sayle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]