Re: analysis of libiberty/cp-demangle.c for libsupc++/__cxa_demangle

[Mark Mitchell <mark at codesourcery dot com>]

Ian Lance Taylor wrote:

> Benjamin Kosnik <bkoz@redhat.com> writes:
>
>  
>
> > I propose the following:
> >
> > 1) your patch of yesterday + my patches to add an type parameter get
> > applied to demangle.h.
> >
> > 2) this gets moved to include/ext/demangle.h
> >
> > 3) We move __cxa_demangle into libsupc++ and use libiberty's code for this function.
> >
> > Thoughts? Is this acceptable to everybody? 
> >    
>
> Sounds fine to me.
>
> Mark, pending this, do you want to approve the patches to the
> libiberty demangler for the 3.4 branch?  These fix a couple of real
> albeit minor bugs, but mostly they make the output of the libiberty
> demangler more like the output of the libstdc++ demangler.
>
> The 3.4 branch will not be hurt if these patches do not go in.  But if
> we do put the proposed libsupc++ patch into 3.4, then I think these
> patches should go into 3.4.
>  
Yes, please check all of these changes (the fixes to the demangler and 
the switch to use the libiberty demangler in V3) into 3.4, once they 
have been approved for mainline.  If only a portion of the changes have 
gone onto the mainline thus far, please put that portion on the 3.4 
branch.  In other words, please keep the mainline in sync with 3.4 in 
this respect.

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com