This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Implement -Wno-variadic-macros
- From: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- To: Richard Henderson <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 21 Feb 2004 01:21:48 +0000 (UTC)
- Subject: Re: Implement -Wno-variadic-macros
- References: <20040219223228.GA20613@redhat.com><Pine.LNX.4.58.0402192339580.9439@digraph.polyomino.org.uk><20040220184521.GB28183@redhat.com>
On Fri, 20 Feb 2004, Richard Henderson wrote:
> I did forget the docs. I had thought that there would be an
> existing testcase for the variadic macro warnings, and so the
> bootstrap itself would take care of the rest. That turns out
> to not be true, so I added some.
In general relying on bootstrap as a testcase would be a bad idea anyway;
it's as far away as possible from a minimised testcase for a specific
issue; and there's no guarantee bootstrap would continue to exercise the
given case (here, it would cease to after a complete transition to calling
the relevant functions directly rather than via a variadic macro). (This
applies to some extent to bugs as well as features: if a bug breaks
bootstrap but there's a minimised testcase available as well, that
minimised testcase should go in the testsuite if not already there - of
course, some bootstrap-breaking bugs will also break cases in the
testsuite when the unbootstrappable compiler is tested with a
cross-compiler.)
--
Joseph S. Myers
jsm@polyomino.org.uk