This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: improve solaris2 and irix6 testsuite profiling bypass

Kaveh R. Ghazi wrote:

Currently solaris2 and irix6 use dg-error to work around lack of
certain profiling support.  However this leaves a "WARNING" in the
testsuite results because while the compilation gets an expected
error, the testsuite warns about the executable not being produced.
E.g. see gcc.dg/nest.c in:

It made more sense to use the testsuite's check for profiling
availability to mark the tests unsupported if possible.  The solaris2
case is quirky because we can do -pg but not -p.

So I modified the testsuite's check_profiling_available function to
accept an argument which describes the profiling test type (-p vs -pg)
and updated the three profiling tests accordingly.  Since it is
possible that irix6 may one day support -pg, I also used the explicit
type check there rather than declare it doesn't support profiling at
all and moved the associated comments inside the testsuite lib code.

Tested via "make check" on sparc-sun-solaris2 and mips-sgi-irix6.5.  I
examined the testsuite .log files to ensure it did the right thing in
each case.

Ok for mainline and 3.4?

Yes, thanks.

Mark Mitchell
CodeSourcery, LLC
(916) 791-8304

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]