This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: A Far Less Ambitious AltiVec patch
- From: Geoff Keating <geoffk at geoffk dot org>
- To: Ziemowit Laski <zlaski at ziemas dot net>
- Cc: gcc-patches at gcc dot gnu dot org, Segher Boessenkool <segher at kernel dot crashing dot org>
- Date: 20 Feb 2004 12:49:37 -0800
- Subject: Re: PING: A Far Less Ambitious AltiVec patch
- References: <6FCF1F56-4D16-11D8-B987-00039390FFE2@ziemas.net><jm7jyibl19.fsf@desire.geoffk.org><44CC32E7-6374-11D8-AC64-00039390FFE2@ziemas.net>
Ziemowit Laski <zlaski@ziemas.net> writes:
> Geoff,
>
> This is not the latest patch. :-) Look here instead:
>
> http://gcc.gnu.org/ml/gcc-patches/2004-02/msg01101.html
I'll look at that.
> >
> > --- 8960,8966 ----
> > || REGNO (XEXP (x, 0)) >= 32)
> > output_operand_lossage ("invalid %%P value");
> > else
> > ! fprintf (file, "%s", reg_names[REGNO (XEXP (x, 0))]);
> > return;
> >
> > case 'q':
> >
> > You should update the comment immediately above this code.
>
> The latest version looks like this:
>
> --- 9019,9031 ----
> || REGNO (XEXP (x, 0)) >= 32)
> output_operand_lossage ("invalid %%P value");
> else
> + #if TARGET_MACHO
> + /* The Darwin assembler requires a register name rather than
> + merely a number. */
> + fprintf (file, "%s", reg_names[REGNO (XEXP (x, 0))]);
> + #else
> fprintf (file, "%d", REGNO (XEXP (x, 0)));
> + #endif
> return;
>
That's worse. Use reg_names always.
> I think I've standardized on just using powerpc*-*-* in all the test
> cases in the latest patch. Is this OK?
That's good.
--
- Geoffrey Keating <geoffk@geoffk.org>