This is the mail archive of the
mailing list for the GCC project.
Re: [tree-ssa] Loop header copying on trees
- From: law at redhat dot com
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: Diego Novillo <dnovillo at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 19 Feb 2004 14:31:04 -0700
- Subject: Re: [tree-ssa] Loop header copying on trees
- Reply-to: law at redhat dot com
In message <20040219205138.GA29716@atrey.karlin.mff.cuni.cz>, Zdenek Dvorak wri
>> In cfglayout.c you added the following line:
>> >+ extern bool cfg_layout_can_duplicate_bb_p (basic_block);
>> Shouldn't we be getting that from a header file somewhere? We generally
>> frown upon exteral declarations in .c files. Similarly for
>> > + extern basic_block cfg_layout_duplicate_bb (basic_block);
>this is intentional. I do not want to put the declaration into a header
>so that it cannot be used directly (it should be only used through
>cfghooks); the other possibility how to achieve this would be to move
>the code to cfgrtl and make it static, but it seems cleaner to keep
>it in a separate file.
OK. Can you put a comment to that effect both at the function declaration
and the function's definition?