This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed patches
- From: Jim Wilson <wilson at specifixinc dot com>
- To: Kazu Hirata <kazu at cs dot umass dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 18 Feb 2004 20:06:26 -0800
- Subject: Re: Unreviewed patches
- References: <20040214.140031.71087211.kazu@cs.umass.edu>
Kazu Hirata wrote:
[patch] loop.c: Remove #if 0'ed all_sets_invariant_p().
http://gcc.gnu.org/ml/gcc-patches/2004-02/msg00705.html
OK.
[patch] Remove commented-out/useless definitions of CASE_VECTOR_PC_RELATIVE.
http://gcc.gnu.org/ml/gcc-patches/2004-02/msg00625.html
OK. There is a typo in the ChangeLog entry CASE_PC_RELATIVE ->
CASE_VECTOR_PC_RELATIVE.
[patch] emit-rtl.c: Remove 3 unused functions.
http://gcc.gnu.org/ml/gcc-patches/2004-02/msg00697.html
OK.
[patch] *hooks.[ch]: Remove unused generic hooks.
http://gcc.gnu.org/ml/gcc-patches/2004-02/msg00698.html
OK.
[patch] mcore: Remove ASM_OUTPUT_EXTERNAL.
http://gcc.gnu.org/ml/gcc-patches/2004-01/msg01357.html
http://gcc.gnu.org/ml/gcc-patches/2004-01/msg02610.html
This one is partially reviewed, but no decision has been made.
That was my partial review, and Nick didn't comment on it. This is OK,
but you must also delete the orphaned comment, as it is no longer of any
use, and is confusing if you leave it in.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com