This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] honor program_transform_name on installation of infomanuals
- From: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- To: Matthias Klose <doko at cs dot tu-berlin dot de>
- Cc: gcc-patches at gcc dot gnu dot org, geoffk at apple dot com
- Date: Wed, 18 Feb 2004 23:36:04 +0000 (UTC)
- Subject: Re: [patch] honor program_transform_name on installation of infomanuals
- References: <16435.62553.933640.399361@gargle.gargle.HOWL>
On Thu, 19 Feb 2004, Matthias Klose wrote:
> +INFO_CPP_NAME = $(shell echo cpp|sed '$(program_transform_name)')
> +INFO_GCC_NAME = $(shell echo gcc|sed '$(program_transform_name)')
> +INFO_GCCINT_NAME = $(shell echo gccint|sed '$(program_transform_name)')
> +INFO_GCCINSTALL_NAME = $(shell echo gccinstall|sed '$(program_transform_name)')
> +INFO_CPPINT_NAME = $(shell echo cppinternals|sed '$(program_transform_name)')
> +
> +INFO_G77_NAME = $(shell echo g77|sed '$(program_transform_name)')
> +INFO_GCJ_NAME = $(shell echo gcj|sed '$(program_transform_name)')
As a GNU make style issue I'd rather these assignments use := to reduce
the number of times the shell expansion is called.
> --- old/gcc/doc/sourcebuild.texi 2004-02-16 23:47:05.000000000 +0100
> +++ new/gcc/doc/sourcebuild.texi 2004-02-17 11:06:10.000000000 +0100
> @@ -771,9 +771,6 @@
> An entry for the target architecture in @file{readings.html} on the
> GCC web site, with any relevant links.
> @item
> -Details of the properties of the back end and target architecture in
> -@file{backends.html} on the GCC web site.
> -@item
I don't see why you're reverting my patch or what this has to do with the
rest of the patch.
--
Joseph S. Myers
jsm@polyomino.org.uk