Re: [patch/m68k] convert USE_GAS into a compile-time constant

[Gunther Nikl <gni at gecko dot de>]

On Tue, Feb 17, 2004 at 09:32:13PM +0100, Bernardo Innocenti wrote:
> >  I am attaching an updated patch which removes USE_GAS which should be
> >  safe. If you think removing USE_GAS should be done later, then please
> >  commit the approved USE_GAS convert patch.
> 
> I'll wait until the subject is cleared in the ongoing thread.

  Ok.

> >-#if MOTOROLA && !defined (USE_GAS)
> >-  return "jsr %0";
> >-#else
> >   return "jbsr %0";
> >-#endif
> > })
> 
> Hmm, is this really correct?  GAS understands both "jsr" and "jbsr", but
> "jbsr" isn't a valid mnemonic for the Motorola syntax.
> 
> Ok, it's a pre-existing problem, so we can address it in a later patch.
> 
> I think it works on MOTOROLA targets only because GAS supports both
> syntaxes at the same time.

  Maybe GAS excepts "jbsr" regardless of asm syntax as an extension. And,
  yes because GAS is now the only supported assembler I thought its safe
  to unconditionally use "jbsr".

  Gunther