This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/m68k] convert USE_GAS into a compile-time constant


Gunther Nikl wrote:
On Tue, Feb 17, 2004 at 01:23:21AM +0100, Bernardo Innocenti wrote:
I can't see you in the "Write after approval" list.  Shall I commit these
approved patches for you?

Yes, please - at least the HPUX_ASM patch.

Done.


  I am attaching an updated patch which removes USE_GAS which should be
  safe. If you think removing USE_GAS should be done later, then please
  commit the approved USE_GAS convert patch.

I'll wait until the subject is cleared in the ongoing thread.



-#if MOTOROLA && !defined (USE_GAS)
-  return "jsr %0";
-#else
   return "jbsr %0";
-#endif
 })

Hmm, is this really correct? GAS understands both "jsr" and "jbsr", but "jbsr" isn't a valid mnemonic for the Motorola syntax.

Ok, it's a pre-existing problem, so we can address
it in a later patch.

I think it works on MOTOROLA targets only because
GAS supports both syntaxes at the same time.

--
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]