This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix exec-charset

From: Eric Christopher <echristo at redhat dot com>
To: Zack Weinberg <zack at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
Date: Thu, 12 Feb 2004 17:04:57 -0800
Subject: Re: [PATCH] fix exec-charset
References: <1076633366.3883.25.camel@dzur.sfbay.redhat.com> <87ptcj6bdw.fsf@codesourcery.com>

On Thu, 2004-02-12 at 17:01, Zack Weinberg wrote:
> Eric Christopher <echristo@redhat.com> writes:
> 
> > As Zack promised here's the patch that fixes exec-charset. Tested by
> > bootstrapping on x86-linux and hand testing with IBM1047 as an execution
> > character set.
> 
> 1) I think you missed extern "C" in the cp/parser.c changes.

Ah heck. I had it in there before. I forgot to migrate it with the new
changes.

> 2) I think it would be clearer if you didn't fold the
>    stop_string_translation action into "asm_keyword".

OK, I can do that.

> 3) How does this interact with error recovery in the C parser?

I have no idea. Got something to test with?

-eric

-- 
Eric Christopher <echristo@redhat.com>

References:
- [PATCH] fix exec-charset
  - From: Eric Christopher
- Re: [PATCH] fix exec-charset
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]