This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] fix exec-charset
On Thu, 2004-02-12 at 17:01, Zack Weinberg wrote:
> Eric Christopher <email@example.com> writes:
> > As Zack promised here's the patch that fixes exec-charset. Tested by
> > bootstrapping on x86-linux and hand testing with IBM1047 as an execution
> > character set.
> 1) I think you missed extern "C" in the cp/parser.c changes.
Ah heck. I had it in there before. I forgot to migrate it with the new
> 2) I think it would be clearer if you didn't fold the
> stop_string_translation action into "asm_keyword".
OK, I can do that.
> 3) How does this interact with error recovery in the C parser?
I have no idea. Got something to test with?
Eric Christopher <firstname.lastname@example.org>