This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix MAKE_THROW_FRAME on x86
- From: Andrew Haley <aph at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Diego Novillo <dnovillo at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, java-patches at gcc dot gnu dot org
- Date: Mon, 9 Feb 2004 10:09:59 +0000
- Subject: Re: Fix MAKE_THROW_FRAME on x86
- References: <1076259047.11082.47.camel@localhost.localdomain><20040208184727.GA19947@redhat.com>
Richard Henderson writes:
> On Sun, Feb 08, 2004 at 11:50:47AM -0500, Diego Novillo wrote:
> > MAKE_THROW_FRAME was taking the address of an incoming parameter and
> > dereferencing it. The aliasing changes I'm working on were correctly
> > assuming that all the stores through that pointer were dead.
>
> This should *really* be fixed by using the SA_SIGINFO signal
> frame instead.
Yes, that's true; the x86 code is rether old. I think all of the
other handlers use SA_SIGINFO, which makes this one a bit of an
anomaly.
Andrew.