This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: My Small AltiVec Patch - TAKE 3
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Ziemowit Laski <zlaski at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 07 Feb 2004 08:31:03 -0400
- Subject: Re: My Small AltiVec Patch - TAKE 3
- References: <EB361C58-5918-11D8-8EE2-000393673036@apple.com>
>>>>> "Ziemowit" == Ziemowit Laski <zlaski@apple.com> writes:
> Per Aldy's request, I've isolated the rs6000-specific stuff
> into a separate patch (the occasional non-rs6000 code is being
Uhh, no you didn't. I still see changes to c-common.*, tree.*, etc.
Please post ONLY the AltiVec non-generic parts of the patch, and test
them.
> touched in a super-obvious way), and re-did the diffs with
> -u (is there a community consensus on this, BTW?).
The guidelines:
http://gcc.gnu.org/contribute.html
...specify either -c3p or -up. It's just easier (in this case) to
review with -u.
> * c-common.c (vector_size_helper): Make externally visible.
> * c-common.h (vector_size_helper): Add prototype.
> * tree.c (make_vector): Make externally visible.
> * tree.h (make_vector): Add prototype.
> * config/darwin.h (TARGET_OPTION_TRANSLATE_TABLE) Refer to
> SUBTARGET_OPTION_TRANSLATE_TABLE for architecture-specific options.
> * config/i386/darwin.h (SUBTARGET_OPTION_TRANSLATE_TABLE). Define it.
None of the above changes are AltiVec specific. Please remove when
you resubmit.
Aldy