This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] [PR14008] Improve diagnostic on invalid type names(regression 3.4/3.5)
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Giovanni Bajo <giovannibajo at libero dot it>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 04 Feb 2004 21:57:25 -0800
- Subject: Re: [C++ PATCH] [PR14008] Improve diagnostic on invalid type names(regression 3.4/3.5)
- Organization: CodeSourcery, LLC
- References: <085901c3eb84$58b170a0$9cba2997@bagio>
Giovanni Bajo wrote:
! if (TREE_CODE (decl) == TEMPLATE_DECL)
! {
! error ("invalid use of template-name `%E' without an argument list",
! decl);
! }
The coding standards say not to use curly-braces around a single statement.
+ static tree
+ cp_parser_make_typename_type (cp_parser *parser, tree scope, tree id)
This new function needs a comment.
With those changes, this patch is OK for mainline, but not for GCC
3.4. It strikes me as just a little too risky, and without enough
payoff to justify it.
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com