This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] gcc: Fix comment typos. Follow spelling conventions.
Hi Richard,
> > - /* FALLTHRU */
> > + /* Fall through. */
>
> Please revert all of these. FALLTHRU is a well-known marker
> from lint days.
Reverted thus. I didn't touch existing "Fall through."
Kazu Hirata
2004-02-04 Kazu Hirata <kazu@cs.umass.edu>
* config/alpha/alpha.c, config/arc/arc.c, config/avr/avr.c,
config/i386/i386.c, config/i386/i386.h, config/i386/i386.md,
config/ia64/ia64.c, config/ia64/unwind-ia64.c,
config/m32r/m32r.c, config/ns32k/ns32k.c, config/pa/pa.c,
config/pdp11/pdp11.c, config/rs6000/rs6000.c,
config/sparc/sparc.c, config/vax/vax.c: Revert the
replacements of "FALLTHRU" with "Fall through" done in the
previous patch.
Index: alpha/alpha.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/alpha/alpha.c,v
retrieving revision 1.350
diff -u -r1.350 alpha.c
--- alpha/alpha.c 4 Feb 2004 19:46:05 -0000 1.350
+++ alpha/alpha.c 4 Feb 2004 20:20:28 -0000
@@ -2112,7 +2112,7 @@
*total = 0;
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case CONST_DOUBLE:
if (x == CONST0_RTX (mode))
@@ -2170,7 +2170,7 @@
*total = COSTS_N_INSNS (1);
return false;
}
- /* Fall through. */
+ /* FALLTHRU */
case ASHIFTRT:
case LSHIFTRT:
@@ -2206,7 +2206,7 @@
*total = COSTS_N_INSNS (1);
return false;
}
- /* Fall through. */
+ /* FALLTHRU */
case ABS:
if (! float_mode_p)
@@ -2214,7 +2214,7 @@
*total = COSTS_N_INSNS (1) + alpha_rtx_cost_data[alpha_cpu].int_cmov;
return false;
}
- /* Fall through. */
+ /* FALLTHRU */
case FLOAT:
case UNSIGNED_FLOAT:
@@ -3275,7 +3275,7 @@
case NE:
if (!fp_p && op1 == const0_rtx)
break;
- /* Fall through. */
+ /* FALLTHRU */
case ORDERED:
cmp_code = reverse_condition (code);
@@ -3708,7 +3708,7 @@
case VOIDmode:
if (GET_CODE (operands[i]) != CONST_INT)
abort ();
- /* Fall through. */
+ /* FALLTHRU */
case DImode:
reg = gen_rtx_REG (DImode, regno);
regno += 1;
@@ -6081,7 +6081,7 @@
case MODE_INT:
/* Do the same thing as PROMOTE_MODE. */
mode = DImode;
- /* Fall through. */
+ /* FALLTHRU */
case MODE_COMPLEX_INT:
case MODE_VECTOR_INT:
Index: arc/arc.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/arc/arc.c,v
retrieving revision 1.49
diff -u -r1.49 arc.c
--- arc/arc.c 4 Feb 2004 19:46:08 -0000 1.49
+++ arc/arc.c 4 Feb 2004 20:20:30 -0000
@@ -834,7 +834,7 @@
*total = 0;
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case CONST:
case LABEL_REF:
Index: avr/avr.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/avr/avr.c,v
retrieving revision 1.113
diff -u -r1.113 avr.c
--- avr/avr.c 4 Feb 2004 19:46:10 -0000 1.113
+++ avr/avr.c 4 Feb 2004 20:20:31 -0000
@@ -4825,7 +4825,7 @@
*total = 2;
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case CONST:
case LABEL_REF:
Index: i386/i386.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.c,v
retrieving revision 1.644
diff -u -r1.644 i386.c
--- i386/i386.c 4 Feb 2004 19:46:13 -0000 1.644
+++ i386/i386.c 4 Feb 2004 20:20:38 -0000
@@ -2573,7 +2573,7 @@
case BLKmode:
if (bytes < 0)
break;
- /* Fall through. */
+ /* FALLTHRU */
case DImode:
case SImode:
case HImode:
@@ -5836,7 +5836,7 @@
default:
return false;
}
- /* Fall through. */
+ /* FALLTHRU */
case SYMBOL_REF:
case LABEL_REF:
@@ -6712,7 +6712,7 @@
case LABEL_REF:
x = XEXP (x, 0);
- /* Fall through. */
+ /* FALLTHRU */
case CODE_LABEL:
ASM_GENERATE_INTERNAL_LABEL (buf, "L", CODE_LABEL_NUMBER (x));
assemble_name (asm_out_file, buf);
@@ -7100,13 +7100,13 @@
fputs ("st(0)", file);
break;
}
- /* Fall through. */
+ /* FALLTHRU */
case 8:
case 4:
case 12:
if (! ANY_FP_REG_P (x))
putc (code == 8 && TARGET_64BIT ? 'r' : 'e', file);
- /* Fall through. */
+ /* FALLTHRU */
case 16:
case 2:
normal:
@@ -8630,15 +8630,15 @@
case CCmode:
if (req_mode == CCGCmode)
return 0;
- /* Fall through. */
+ /* FALLTHRU */
case CCGCmode:
if (req_mode == CCGOCmode || req_mode == CCNOmode)
return 0;
- /* Fall through. */
+ /* FALLTHRU */
case CCGOCmode:
if (req_mode == CCZmode)
return 0;
- /* Fall through. */
+ /* FALLTHRU */
case CCZmode:
break;
@@ -14653,7 +14653,7 @@
case HImode:
case SImode:
operand = gen_lowpart (DImode, operand);
- /* Fall through. */
+ /* FALLTHRU */
case DImode:
emit_insn (
gen_rtx_SET (VOIDmode,
@@ -14693,7 +14693,7 @@
/* It is better to store HImodes as SImodes. */
if (!TARGET_PARTIAL_REG_STALL)
operand = gen_lowpart (SImode, operand);
- /* Fall through. */
+ /* FALLTHRU */
case SImode:
emit_insn (
gen_rtx_SET (VOIDmode,
@@ -15058,7 +15058,7 @@
return false;
}
}
- /* Fall through. */
+ /* FALLTHRU */
case ROTATE:
case ASHIFTRT:
@@ -15166,7 +15166,7 @@
return true;
}
}
- /* Fall through. */
+ /* FALLTHRU */
case MINUS:
if (FLOAT_MODE_P (mode))
@@ -15174,7 +15174,7 @@
*total = COSTS_N_INSNS (ix86_cost->fadd);
return false;
}
- /* Fall through. */
+ /* FALLTHRU */
case AND:
case IOR:
@@ -15188,7 +15188,7 @@
<< (GET_MODE (XEXP (x, 1)) != DImode)));
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case NEG:
if (FLOAT_MODE_P (mode))
@@ -15196,7 +15196,7 @@
*total = COSTS_N_INSNS (ix86_cost->fchs);
return false;
}
- /* Fall through. */
+ /* FALLTHRU */
case NOT:
if (!TARGET_64BIT && mode == DImode)
Index: i386/i386.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.h,v
retrieving revision 1.372
diff -u -r1.372 i386.h
--- i386/i386.h 4 Feb 2004 20:00:55 -0000 1.372
+++ i386/i386.h 4 Feb 2004 20:20:40 -0000
@@ -580,7 +580,7 @@
{ \
case '3': \
builtin_define ("__tune_pentium3__"); \
- /* Fall through. */ \
+ /* FALLTHRU */ \
case '2': \
builtin_define ("__tune_pentium2__"); \
break; \
Index: i386/i386.md
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.md,v
retrieving revision 1.508
diff -u -r1.508 i386.md
--- i386/i386.md 4 Feb 2004 19:46:14 -0000 1.508
+++ i386/i386.md 4 Feb 2004 20:20:44 -0000
@@ -1955,7 +1955,7 @@
case TYPE_SSEMOV:
if (get_attr_mode (insn) == MODE_TI)
return "movdqa\t{%1, %0|%0, %1}";
- /* Fall through. */
+ /* FALLTHRU */
case TYPE_MMXMOV:
/* Moves from and into integer register is done using movd opcode with
REX prefix. */
@@ -2005,7 +2005,7 @@
case TYPE_SSEMOV:
if (get_attr_mode (insn) == MODE_TI)
return "movdqa\t{%1, %0|%0, %1}";
- /* Fall through. */
+ /* FALLTHRU */
case TYPE_MMXMOV:
return "movq\t{%1, %0|%0, %1}";
case TYPE_MULTI:
Index: ia64/ia64.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/ia64/ia64.c,v
retrieving revision 1.271
diff -u -r1.271 ia64.c
--- ia64/ia64.c 4 Feb 2004 20:00:57 -0000 1.271
+++ ia64/ia64.c 4 Feb 2004 20:20:48 -0000
@@ -425,7 +425,7 @@
|| GET_CODE (XEXP (XEXP (op, 0), 0)) != SYMBOL_REF)
break;
op = XEXP (XEXP (op, 0), 0);
- /* Fall through. */
+ /* FALLTHRU */
case SYMBOL_REF:
if (CONSTANT_POOL_ADDRESS_P (op))
@@ -5299,7 +5299,7 @@
case SUBREG:
x = SUBREG_REG (x);
- /* Fall through. */
+ /* FALLTHRU */
case REG:
if (REGNO (x) == AR_UNAT_REGNUM)
{
@@ -5550,7 +5550,7 @@
need_barrier = 1;
break;
}
- /* Fall through. */
+ /* FALLTHRU */
case INSN:
if (GET_CODE (PATTERN (insn)) == USE
Index: ia64/unwind-ia64.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/ia64/unwind-ia64.c,v
retrieving revision 1.22
diff -u -r1.22 unwind-ia64.c
--- ia64/unwind-ia64.c 4 Feb 2004 19:46:18 -0000 1.22
+++ ia64/unwind-ia64.c 4 Feb 2004 20:20:49 -0000
@@ -1614,7 +1614,7 @@
*nat = 1;
return;
}
- /* Fall through. */
+ /* FALLTHRU */
case UNW_NAT_NONE:
dummy_nat = 0;
Index: m32r/m32r.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/m32r/m32r.c,v
retrieving revision 1.86
diff -u -r1.86 m32r.c
--- m32r/m32r.c 4 Feb 2004 20:00:59 -0000 1.86
+++ m32r/m32r.c 4 Feb 2004 20:20:50 -0000
@@ -1689,7 +1689,7 @@
*total = 0;
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case CONST:
case LABEL_REF:
Index: ns32k/ns32k.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/ns32k/ns32k.c,v
retrieving revision 1.45
diff -u -r1.45 ns32k.c
--- ns32k/ns32k.c 4 Feb 2004 20:01:02 -0000 1.45
+++ ns32k/ns32k.c 4 Feb 2004 20:20:51 -0000
@@ -598,7 +598,7 @@
case MULT:
cost += 2;
- /* Fall through. */
+ /* FALLTHRU */
case PLUS:
cost += ns32k_address_cost (XEXP (operand, 0));
cost += ns32k_address_cost (XEXP (operand, 1));
Index: pa/pa.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/pa/pa.c,v
retrieving revision 1.241
diff -u -r1.241 pa.c
--- pa/pa.c 4 Feb 2004 19:46:22 -0000 1.241
+++ pa/pa.c 4 Feb 2004 20:20:55 -0000
@@ -1432,7 +1432,7 @@
*total = COSTS_N_INSNS (14);
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case UDIV:
case MOD:
Index: pdp11/pdp11.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/pdp11/pdp11.c,v
retrieving revision 1.37
diff -u -r1.37 pdp11.c
--- pdp11/pdp11.c 4 Feb 2004 19:46:23 -0000 1.37
+++ pdp11/pdp11.c 4 Feb 2004 20:20:56 -0000
@@ -1084,7 +1084,7 @@
*total = 0;
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case CONST:
case LABEL_REF:
Index: rs6000/rs6000.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/rs6000/rs6000.c,v
retrieving revision 1.590
diff -u -r1.590 rs6000.c
--- rs6000/rs6000.c 4 Feb 2004 19:46:23 -0000 1.590
+++ rs6000/rs6000.c 4 Feb 2004 20:21:02 -0000
@@ -8974,7 +8974,7 @@
case 'Q':
if (TARGET_MFCRF)
fputc (',',file);
- /* Fall through. */
+ /* FALLTHRU */
else
return;
@@ -15581,7 +15581,7 @@
*total = COSTS_N_INSNS (2);
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case UDIV:
case UMOD:
Index: sparc/sparc.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/sparc/sparc.c,v
retrieving revision 1.288
diff -u -r1.288 sparc.c
--- sparc/sparc.c 4 Feb 2004 20:01:04 -0000 1.288
+++ sparc/sparc.c 4 Feb 2004 20:21:06 -0000
@@ -8440,7 +8440,7 @@
*total = 0;
return true;
}
- /* Fall through. */
+ /* FALLTHRU */
case HIGH:
*total = 2;
Index: vax/vax.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/vax/vax.c,v
retrieving revision 1.54
diff -u -r1.54 vax.c
--- vax/vax.c 4 Feb 2004 19:46:25 -0000 1.54
+++ vax/vax.c 4 Feb 2004 20:21:06 -0000
@@ -557,7 +557,7 @@
return 1;
if (outer_code == PLUS && (unsigned HOST_WIDE_INT) -INTVAL (x) <= 077)
return 1;
- /* Fall through. */
+ /* FALLTHRU */
case CONST:
case LABEL_REF: