This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC Fix for 9964.cc and 9507.cc on ia64-hpux
Benjamin Kosnik <bkoz@redhat.com> writes:
> For the 3.4 patches, kill all
>
> * config/abi/alpha-freebsd5/baseline_symbols.txt
> * config/abi/alpha-linux-gnu/baseline_symbols.txt
> * config/abi/hppa-linux-gnu/baseline_symbols.txt
> * config/abi/i386-freebsd4/baseline_symbols.txt
> * config/abi/i386-freebsd5/baseline_symbols.txt
> * config/abi/i486-linux-gnu/baseline_symbols.txt
> * config/abi/ia64-linux-gnu/baseline_symbols.txt
> * config/abi/mips-linux-gnu/baseline_symbols.txt
> * config/abi/sparc-freebsd5/baseline_symbols.txt
> * config/abi/sparc-linux-gnu/baseline_symbols.txt
> * config/abi/x86_64-linux-gnu/baseline_symbols.txt:
> Remove entry for __basic_file<char>::_M_open_mode.
>
> These have no meaning on the 3.4 branch until there is a 3.4.0 to
> establish a 3.4.0 ABI export list, so there is no point in editing them.
Ok.
> Also, minor minor
>
> + static const char*
> + fopen_mode(std::ios_base::openmode mode)
>
> can just be
>
> + const char*
> + fopen_mode(std::ios_base::openmode mode)
Umm. Why *not* make it static? It has no business being called
outside this file.
Unfortunately my tests all bombed out because I foolishly tried to do
--disable-multilib on ia64-hpux to save time. So I won't be checking
this in until (best case) tomorrow morning.
zw