This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch]: more fixes for encode-[2-4].m testcases

From: Ziemowit Laski <zlaski at apple dot com>
To: Jim Wilson <wilson at specifixinc dot com>
Cc: gcc-patches at gcc dot gnu dot org, "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
Date: Tue, 3 Feb 2004 14:14:44 -0800
Subject: Re: [Patch]: more fixes for encode-[2-4].m testcases
References: <200402020232.i122WUIh019286@caip.rutgers.edu> <1075846309.1031.11.camel@leaf.tuliptree.org>

On 3 Feb, 2004, at 14.11, Jim Wilson wrote:

On Sun, 2004-02-01 at 18:32, Kaveh R. Ghazi wrote:

	* objc.dg/encode-2.m, objc.dg/encode-3.m, objc.dg/encode-4.m: Fix
	tests for systems where `char' is unsigned by default.

OK.

I don't fully understand what the patch does, but it makes testsuite
failures go away, so it must be good.  I was wondering why you didn't
use "signed char:(signed char)" but I see that the Objective C compiler
won't accept that, so your patch does seem like the right fix.

'char:(signed char)' should work fine, as should adding '-fsigned-char' to the dg-options.

--Zem
--------------------------------------------------------------
Ziemowit Laski                 1 Infinite Loop, MS 301-2K
Mac OS X Compiler Group        Cupertino, CA USA  95014-2083
Apple Computer, Inc.           +1.408.974.6229  Fax .5477

References:
- [Patch]: more fixes for encode-[2-4].m testcases
  - From: Kaveh R. Ghazi
- Re: [Patch]: more fixes for encode-[2-4].m testcases
  - From: Jim Wilson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]