This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [applied mips patch] finish removals mips rewrite branch merge

Eric Christopher <> writes:
> On Sun, 2004-02-01 at 00:06, wrote:
>> I noticed a couple of months ago ("I've been busy" 8-) that there were
>> a couple of predicates in the MIPS port removed during the mips
>> rewrite branch merge, which still had some vestigial references
>> hanging around.
>> Checked in as obvious, after building the compiler for target
>> mipsisa64-elf (w/ sources a couple of days ago; i tried again just
>> now, some some unrelated things seemed broken) and checking.
> Right. I've got a patch for that I need to check in.

Well, I guess you're asleep by now ;), so I took the liberty of checking
in the patch below.

For the record, Ian's recent patch caused us to abort if a pattern had
redundant %s in second and subsequent alternatives.  I checked that
adddi3_internal_2 is the only such pattern in

I've applied this to 3.4 too since it's obviously safe and will prevent
any breakage if Ian's patch is backported.


	* config/mips/ (adddi3_internal_2): Remove superfluous %s.

Index: config/mips/
RCS file: /cvs/gcc/gcc/gcc/config/mips/,v
retrieving revision 1.212
diff -u -d -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.212
--- config/mips/	31 Jan 2004 02:07:02 -0000	1.212
+++ config/mips/	1 Feb 2004 11:44:03 -0000
@@ -976,7 +976,7 @@ (define_split
 (define_insn "adddi3_internal_2"
   [(set (match_operand:DI 0 "register_operand" "=d,d,d")
-	(plus:DI (match_operand:DI 1 "register_operand" "%d,%d,%d")
+	(plus:DI (match_operand:DI 1 "register_operand" "%d,d,d")
 		 (match_operand:DI 2 "small_int" "P,J,N")))
    (clobber (match_operand:SI 3 "register_operand" "=d,d,d"))]

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]