Re: Unreviewed patch - simple one liner

[Jim Wilson <wilson at specifixinc dot com>]

Daniel Berlin wrote:
> * timevar.c (timevar_print): Print something about checking if it is on.

This is a good idea.  Some things I noticed while looking at it:
- The message is outside the HAVE_*_TIME ifdefs, which means it is 
always printed if none of these macros is defined, even though nothing 
else gets printed in this case.  Is this intentional or accidental?  If 
intentional, it probably should be commented.  Otherwise, this looks 
like a bug to me.
- The message printed is longer than 80 lines.  Maybe the dot (.) should 
be followed by a newlib (\n) rather than two spaces?  Otherwise some 
people might have trouble reading the message.
- The message would be more visible if it was printed just before the 
"Execution times (seconds):" line, with a blank line preceeding and 
following it.  Putting it at the end means that people who look only at 
the first few entries may miss it.  However, since this info is always
printed when cc1 is run standalone, it might be annoying to gcc 
maintainers to do it this way, as we might get sick of the messsage.  So 
I think this placement is OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com