This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fr30: Hookize some target macros.
- From: Jim Wilson <wilson at specifixinc dot com>
- To: Kazu Hirata <kazu at cs dot umass dot edu>
- Cc: nickc at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 28 Jan 2004 15:36:32 -0800
- Subject: Re: [patch] fr30: Hookize some target macros.
- References: <20040124.165631.74744012.kazu@cs.umass.edu>
Kazu Hirata wrote:
The patch has one caveat. fr30_setup_incoming_varargs() has one line
of code #if 0'ed by STRICT_ARGUMENT_NAMING. I replaced with a
run-time check:
The code has been there effectively unchanged since it was contributed
to the FSF. If there was ever any reason for doing this, it is probably
in the Red Hat CVS tree, and only a Red Hat employee can check that.
You could at least add a ??? comment pointing out that the run-time test
for strict_argument_naming seems to be unnecessary.
Built cc1 of fr30-elf. OK to apply?
OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com