This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR7297: Fix size of sjlj's jbuf for MIPS


On Tue, Jan 20, 2004 at 09:02:44AM +0000, Richard Sandiford wrote:
> The comments in builtins.c say that __builtin_setjmp() is supposed to
> take a pointer to 5 words.  Going by that, the MIPS version should be
> in the clear, since it only needs 4.  But the sjlj code tries to save
> a few bytes by using the following type for the jbuf field:
> 
>       /* This is 2 for builtin_setjmp, plus whatever the target requires
> 	 via STACK_SAVEAREA_MODE (SAVE_NONLOCAL).  */
>       tmp = build_int_2 ((GET_MODE_SIZE (STACK_SAVEAREA_MODE (SAVE_NONLOCAL))
> 			  / GET_MODE_SIZE (Pmode)) + 2 - 1, 0);
>       ...

I think it'd be better to just set this to 5.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]