This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Use filenames.h in libiberty/lbasename.c


>   - filenames.h claims to be part of BFD even though it's in both
>     repositories.

It is handled as part of libiberty now.  I'm not sure we can change
that part of the copyright notice without the usual legal hoops.

>   - lbasename.c (based on code copied out of GCC at some point) checks
>     __DJGPP__ and filenames.h doesn't.

DJGPP's gcc always defines __MSDOS__, and we (the djgpp crew) advise
that __MSDOS__ should be tested when you're interested in dos-specific
features of DJGPP (whereas __DJGPP__ should be tested when you want
djgpp-specific features).

> I'm pretty sure that neither of those is a real problem.  OK?

Ok.

> 2003-12-22  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	PR debug/13272
> 	* Makefile.in (lbasename.o): Depend on filenames.h.
> 	* lbasename.c: Include "filenames.h" instead of defining
> 	its macros locally.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]