This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR C/9163, ICE in C99 mode after error withchecking


Andrew Pinski <pinskia@physics.uc.edu> writes:

> [Lets try this one more time.
> Sending again since it has not come through yet.]
>
> Even though I know that Zack is working on a rewrite of c-decl.c, I
> thought I
> would try to fix this bug which involves to change c-decl.c as this is a
> regression and I would like to get regressions fixed sooner rather than
> later.
>
> One of the problems is that we are trying to expand a function which has
> problems.  All the other problems were caused by error checking.
>
> OK?

This patch does not interfere with my rewrite, and is mostly the right
thing.  One question...

> -  BLOCK_SUPERCONTEXT (DECL_INITIAL (fndecl)) = fndecl;
> +  if (DECL_INITIAL (fndecl) != error_mark_node)
> +    BLOCK_SUPERCONTEXT (DECL_INITIAL (fndecl)) = fndecl;

as long as we're being paranoid here, what about the possibility that
DECL_INITIAL is null?  Same below in c_expand_body, and for
DECL_RESULT.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]