This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add TPF config support to libstdc++
- From: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>
- To: phil at jaj dot com (Phil Edwards)
- Cc: weigand at i1 dot informatik dot uni-erlangen dot de (Ulrich Weigand), libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, darcypj at us dot ibm dot com
- Date: Fri, 19 Dec 2003 02:12:24 +0100 (CET)
- Subject: Re: [PATCH] Add TPF config support to libstdc++
Phil Edwards wrote:
> On Thu, Dec 18, 2003 at 11:54:20PM +0100, Ulrich Weigand wrote:
> > *************** case "${host_os}" in
> > *** 186,191 ****
> > --- 186,194 ----
> > solaris2.[789] | solaris2.1[0-9])
> > os_include_dir="os/solaris/solaris2.7"
> > ;;
> > + tpf)
> > + os_include_dir="os/tpf"
> > + ;;
>
> This should already be handled by the defaults, I believe.
Hmm, the default case is
*)
os_include_dir="os/generic"
;;
so I should think this *is* needed.
> > + // TPF is a big endian OS, let it be known here.
> > + #define _BIG_ENDIAN 1
> > + #define BIG_ENDIAN 1
>
> This is wrong. _BIG_ENDIAN is okay; it's used while building libmath.
> BIG_ENDIAN is not okay. This file will be seen by every program using the C++
> library; you cannot define user-space macros like that.
OK, I'll change this.
> > + #include <features.h>
> > +
> > + // We must not see the optimized string functions GNU libc defines.
> > + #define __NO_STRING_INLINES
>
> You don't need to include features.h just to define this... the Linux
> version includes that header to get the definition of __GLIBC__, which it
> then tests.
OK, I'll remove the include.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de