This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Cleanup and enhance dominator infrastructure


On Thu, 2003-12-18 at 09:37, Zdenek Dvorak wrote:
> Hello,
> 
> > > as pointed out by Daniel, there is a mistake in the part of the patch in
> > > tree-ssa-pre.c (I did not notice that the arguments of
> > > fast_a_dominates_b are reversed wrto dominated_by_p).
> > 
> > Could you send me a complete patch including these new fixes?
> 
> here is the actual version of the patch; nothing else was changed
> (except for resolving a few conflicts), so the comments/changelogs at
> the original message should be applicable.

The new dom children interface is much nicer than before. Thanks.  A
couple of comments below:

In the definition of enum dom_state add a comment specifying that the
enum values are ordered from "worst" to "best".  We use those semantics
in places like cleanup_control_expr_graph.
  
> ! #ifdef DEBUG_ET
>
Have you bootstrapped with DEBUG_ET enabled?

  
> ! static int len;
> ! static void *datas[100000];
> ! static int depths[100000];
>
Please #define these values and add guards in record_path_before_1.

OK with those changes.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]