This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Use `inform' instead of `warning' on mips-irix with-g -mabi=32


Kaveh R. Ghazi wrote:
there are some cases where a diagnostic shouldn't cause a -Werror
failure.  IMHO this warning is one of them.  Changing this diagnostic
to a `note' allows us to remove the -Wno-error from target files in a
bootstrap.

FYI These changes may affect the testsuite and dejagnu, because they have code to prune warnings, and some of the sed patterns check for the string "warning".


dejagnu/lib/target.exp (prune_warnings) for instance has

regsub -all "(^|\n)(cc1: warning: -mabi=32 does not support -g\[^\n\]*\n?)+\" $text "\\1" text
regsub -all "(^|\n)(cc1plus: warning: -mabi=32 does not support -g\[^\n\]*\\n?)+" $text "\\1" text


These are already broken, because the warning text changed, but they are also doubly broken now because we emit note instead of warning.

Similarly, in gcc/testsuite/lib/prune.exp there are some sed patterns that check for warning.

It probably isn't worth fixing any of these unless someone runs into a problem.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]