This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [csl-hpux-branch]: Use targetm structure for manglings


Zack Weinberg wrote:
Nathan Sidwell <nathan@codesourcery.com> writes:


Zack,
this patch uses the target structure to override the builtin macros, thus
implementing the hpux long double mangling in a more mainline friendly manner.

If we ever get proper singleton canonical type nodes there will be no
need to loop in the mangling using c_common_type_for_mode. But that's
for another day.

built and tested with a native i686-pc-linux-gnu and an ia64-hp-hpux11.23
cross compiler. ok for csl-hpux-branch?


This is looking good.  Please check with Geoff that this arrangement
won't cause problems for PCH.
Yes, I emailed Geoff in developing this patch (and fixed a mainline bug
in the same area)

> Also, the hash table initialization
would be better broken out into a separate function, called from
init_mangle.
Unfortunately there is a twisty interdependency on initializing the
mangler. Part needs to be done early and parts late. IMO lazy initialization
is the simplest manner, and inline with the other hash table in mangle.c.

And, since you removed all of the /* Foreign language type mangling
section */, you should delete that comment too.
ok with this one change?

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
         The voices in my head said this was stupid too
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]