This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH rewrite duplicate_decls to not modify olddecl (fixes gcc/12336)
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: "Zack Weinberg" <zack at codesourcery dot com>
- Cc: Per Bothner <per at bothner dot com>, gcc-patches at gcc dot gnu dot org
- Date: 09 Dec 2003 10:48:11 +0100
- Subject: Re: PATCH rewrite duplicate_decls to not modify olddecl (fixes gcc/12336)
- Organization: Integrable Solutions
- References: <3FD57AB3.7040107@bothner.com> <87ad62mjg3.fsf@codesourcery.com>
"Zack Weinberg" <zack@codesourcery.com> writes:
| I don't see any problems with your patch, however, I agree that it is
| far from obviously safe. I'm going to test it on x86-linux and
| ia64-hpux tonight, and sparc-solaris2 after that machine finishes
| doing some other work. I'd also appreciate a second opinion from
| another maintainer, ideally Joseph or Richard. Provided that my
| testing goes well and that the second opinion is positive, I'm willing
| to approve this for 3.4.
duplicate_decls is, some sense, duplicated in the C++ front-end also.
What are the reasons Per's modification are not needed there?
-- Gaby, who has always been "amazed" by duplicate_decls