This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR driver/13211 using -###, warns about unusedlinker file
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: Jim Wilson <wilson at tuliptree dot org>, GCC Patches<gcc-patches at gcc dot gnu dot org>
- Date: Thu, 04 Dec 2003 22:22:08 -0800
- Subject: Re: [PATCH] Fix PR driver/13211 using -###, warns about unusedlinker file
- References: <5855E680-220F-11D8-AABA-000393A6D2F2@physics.uc.edu><BEA06FF8-26DF-11D8-9E32-000393A6D2F2@physics.uc.edu>
Andrew Pinski <pinskia@physics.uc.edu> writes:
> On Nov 28, 2003, at 17:57, Andrew Pinski wrote:
>
>> Try the following and you get a warning about unused linker files but
>> the warning is not true at all:
>> touch test.o
>> gcc -### test.o
>>
>> This patch fixes that:
>> ChangeLog:
>> * gcc.c (main): The linker also ran
>> when verbose_only_flag is true.
>
>
> Based on Zack's and Jim's comments in the bug, here is a new patch.
>
> Ok for 3.3 branch and the mainline?
>
> ChangeLog:
> * gcc.c (execute): Increment execution_count when returning
> early because verbose_only_flag is true.
I'd like slight wording changes to the comment:
> + /* If verbose_only_flag, then the execution_count is incremented
> + because verbose_only_flag should act as the spec was excuted. */
Suggest
/* verbose_only_flag should act as if the spec was
executed, so increment execution_count before
returning. This prevents spurious warnings about
unused linker input files, etc. */
If Jim has no further comments, OK with that change.
zw