This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Removal of gotos from cfg based ir


Hello,

> Im running into a problem with my new code with your last change:

[snip]

> You are calling tree_ssa_finish outside the if (n_basic_blocks)
> conditional, but init_tree_ssa is never called in this case. Its causing
> me segfaults since there is an assumption that if you call
> delete_tree_ssa, that init_tree_ssa must have been called.

I don't see any such dependancy in delete_tree_ssa; I assume you mean
some code you added there?

> There shouldn't be a dependancy on ssa if its never initialized... I
> suspect the tree_ssa_finish can be moved inside the conditional and a
> simple ELSE clause to take care of the 0 BB case?

Probably.  Or possibly you could move the actions you have added into
delete_tree_ssa to rewrite_out_of_ssa (I don't know what they are,
so I cannot know whether it is suitable solution).

Zdenek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]