This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Bring back PHI management
- From: law at redhat dot com
- To: Richard Henderson <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 02 Dec 2003 12:17:40 -0700
- Subject: Re: [tree-ssa] Bring back PHI management
- Reply-to: law at redhat dot com
In message <20031202050048.GA31561@redhat.com>, Richard Henderson writes:
>On Mon, Dec 01, 2003 at 09:09:24PM -0700, law@redhat.com wrote:
>> + /* Resize an existing PHI node. The only way is up. Return the
>> + possibly relocated phi. */
>> +
>> + void
>> + resize_phi_node (tree *phi, int len)
>
>I notice you don't put the old node on the free list...
Fixed locally.
>> + new_phi = ggc_realloc (*phi, size);
>
>I would much prefer if you treated ggc_realloc as with the libc malloc.
>Namely, that the old contents of the node are dead immediately. Which
>means...
Actually, we don't look at the contents of the old node -- we only care
about its address. I do note that in the case where ggc_ralloc gives us
our original node the code to update the PHI chains is totally pointless :-)
jeff