This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix x86 segfault on thread-local asm operands
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 29 Nov 2003 18:56:53 +0000
- Subject: Re: Fix x86 segfault on thread-local asm operands
- References: <874qwok2ak.fsf@redhat.com> <20031128223211.GD5843@redhat.com>
Richard Henderson <rth@redhat.com> writes:
> Or perhaps you could use dg-error and add -Werror to the options?
OK, here's what I committed (after checking that the test case still passes).
Richard
* stmt.c (expand_asm_operands): Check whether force_const_mem
succeeded.
testsuite/
* gcc.dg/tls/asm-1.C: New test.
Index: stmt.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/stmt.c,v
retrieving revision 1.336
diff -c -d -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.336 stmt.c
*** stmt.c 20 Nov 2003 00:28:39 -0000 1.336
--- stmt.c 29 Nov 2003 18:50:25 -0000
*************** expand_asm_operands (tree string, tree o
*** 1712,1724 ****
if (CONSTANT_P (op))
{
! op = force_const_mem (TYPE_MODE (type), op);
! op = validize_mem (op);
}
! else if (GET_CODE (op) == REG
! || GET_CODE (op) == SUBREG
! || GET_CODE (op) == ADDRESSOF
! || GET_CODE (op) == CONCAT)
{
tree qual_type = build_qualified_type (type,
(TYPE_QUALS (type)
--- 1712,1727 ----
if (CONSTANT_P (op))
{
! rtx mem = force_const_mem (TYPE_MODE (type), op);
! if (mem)
! op = validize_mem (mem);
! else
! op = force_reg (TYPE_MODE (type), op);
}
! if (GET_CODE (op) == REG
! || GET_CODE (op) == SUBREG
! || GET_CODE (op) == ADDRESSOF
! || GET_CODE (op) == CONCAT)
{
tree qual_type = build_qualified_type (type,
(TYPE_QUALS (type)
*** /dev/null Tue Mar 19 20:01:09 2002
--- testsuite/gcc.dg/tls/asm-1.c Sat Nov 29 18:49:09 2003
***************
*** 0 ****
--- 1,7 ----
+ /* { dg-options "-Werror" } */
+ __thread int i;
+
+ int foo ()
+ {
+ asm volatile ("" :: "m" (&i)); /* { dg-error "lvalue" } */
+ }