This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speed up genattrtab

This is good, but:

- No ChangeLog entry.
- Didn't say where you tested it.  I presume you have built at least
  one target with strcmp_check set to the debugging version.
- Please update the comment above find_attr to say what it does to
  its first parameter.
- You missed a spot for DEF_ATTR_STRING:

    return attr_rtx (EQ_ATTR, attr_string (name, strlen (name)),
! 		   DEF_ATTR_STRING (value));

With these changes, it's OK to commit.

-- 
- Geoffrey Keating <geoffk@geoffk.org>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]