This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: RFA reload.c patch
On Fri, 2003-11-14 at 09:02, Eric Botcazou wrote:
> > Got an OK from rth on this revised patch (turns out I'd missed that
> > memory_operand calls general_operand which calls
> > GO_IF_LEGITIMATE_ADDRESS.
>
> FYI this patch caused a stage3 bootstrap failure on SPARC (miscompilation of
> the stage2 compiler). Given Jim's opinion on the patch, I won't try to
> further debug.
>
Hunh. Weird. A performance regression possibly, but I wouldn't have
guessed miscompilation. At any rate, I've checked in an improved patch.
> > Bootstrapped and regtested on x86-linux and checked into mainline.
>
> It might be nice to test those hot patches on at least 2 platforms.
Well, I did regtest on frv-elf as well (which is where I found the bug),
but I probably wouldn't have tested sparc anyways. Too slow :)
Sorry about the breakage.
--
Eric Christopher <echristo@redhat.com>