This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,m68k] Get rid of #ifdef MOTOROLA
On Tue, Nov 11, 2003 at 07:16:46PM +0100, Bernardo Innocenti wrote:
> >@@ -3000,9 +2998,9 @@ print_operand_address (FILE *file, rtx a
> > break;
> > }
> > }
> >- if (addr != 0 && ireg != 0)
> >- putc (',', file);
> > } /* !MOTOROLA */
> >+ if (ireg != 0)
> >+ putc (',', file);
> > if (ireg != 0 && GET_CODE (ireg) == MULT)
> > {
> > scale = INTVAL (XEXP (ireg, 1));
> >-- cut2 --
>
> Hmmm... are you sure about that?
No :)
> The tests are slightly different:
>
> >- if (ireg != 0)
> >- if (addr != 0 && ireg != 0)
>
> In the second case, we must avoid printing the comma when addr is
> 0, because in the MOTOROLA case the address is printed out of the
> parentheses, like this:
>
> foo address(reg,ireg)
Convinced. In that case I suggest to move the !MOTOROLA putc inside
the "if (addr != 0)" thus avoiding another test of addr.
Gunther