This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [cs] rewrite duplicate_decls to not modify olddecl
- From: Roger Sayle <roger at eyesopen dot com>
- To: Per Bothner <per at bothner dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 7 Nov 2003 17:51:09 -0700 (MST)
- Subject: Re: [cs] rewrite duplicate_decls to not modify olddecl
On Fri, 7 Nov 2003, Per Bothner wrote:
> I checked in the following patch to the compile server branch. It does
> have a few places where I'm not sure what is wanted. (Look for the #if 0
> sections.) However, the patch is independent of (though needed by) the
> compile server, and could probably be merged into (say) the tree-ssa
> branch with a little more polishing and testing.
In fact, I believe that this patch or one very similar should resolve
PR gcc/12336, which is targeted for gcc 3.4, so with the "little more
polishing and testing", it may also be suitable for mainline.
The failure mode of PR 12336 is that duplicate_decls overwrites the
olddecl for one of GCC's builtins, which we then attempt to reuse to
compile the following compilation unit. At the very least, all DECLs
between first_builtin_decl and last_builtin_decl can't be modified
in-place if we hope to process multiple compilation units.
Any chance you could give your patch a spin against mainline, to see
whether those failures on the cs-branch are caused by other changes?
Many thanks in advance,
Roger
--