This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Makefile] Bootstrap with -Wold-style-definition - warn2.diff [1/1]
In article <200310302345.h9UNjLKn003356@caip.rutgers.edu>,
ghazi@caip.rutgers.edu says...
> > A simple patch which adds in -Wold-style-definition to the bootstrap
> > to which should help everyone remember to retain the C90 conversion.
> >
> > 2003-10-30 Kelley Cook <kcook@gcc.gnu.org>
> >
> > * Makefile.in (LOOSE_WARN_XGCC): New variable.
> > (POSTSTAGE1_FLAGS_TO_PASS): Use it.
> >
>
> Great idea, thanks.
>
> Question: why do you add the new LOOSE_WARN_XGCC variable? I would
> think putting -Wold-style-definition in STRICT2_WARN would serve just
> as well, no?
I guess that the comment misled me on how it worked, so I didn't try it.
This oneliner accomplishes the same thing.
OK?
2003-10-30 Kelley Cook <kcook@gcc.gnu.org>
* Makefile.in (STRICT2_WARN): Add -Wold-style-definition.
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
retrieving revision 1.1185
diff -u -r1.1185 Makefile.in
--- Makefile.in 27 Oct 2003 00:26:42 -0000 1.1185
+++ Makefile.in 31 Oct 2003 01:46:44 -0000
@@ -152,7 +152,7 @@
# stage1, as not all versions of gcc understand -Wno-long-long.
LOOSE_WARN = -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
STRICT_WARN = @strict1_warn@
-STRICT2_WARN = -pedantic -Wno-long-long @WERROR@
+STRICT2_WARN = -pedantic -Wno-long-long -Wold-style-definition @WERROR@
# This is set by --enable-checking. The idea is to catch forgotten
# "extern" tags in header files.