Re: [PATCH, committed]: Zone collector

[Daniel Berlin <dberlin at dberlin dot org>]

On Oct 27, 2003, at 1:00 PM, Kelley Cook wrote:

> Daniel,
>
> Attempting to bootstrap on i686-pc-cygwin with --with-gc=zone, I get
>
> $ gcc -c --save-temps  -g  -DIN_GCC   -W -Wall -Wwrite-strings 
> -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long 
> -DHAVE_CONFIG_H    -I. -I. -I../../gcc-snapshot/gcc 
> -I../../gcc-snapshot/gcc/. -I../../gcc-snapshot/gcc/../include 
> ../../gcc-snapshot/gcc/ggc-zone.c -o ggc-zone.o
> ../../gcc-snapshot/gcc/ggc-zone.c: In function `alloc_small_page':
> ../../gcc-snapshot/gcc/ggc-zone.c:626: error: `entry_size' undeclared 
> (first use in this function)
> ../../gcc-snapshot/gcc/ggc-zone.c:626: error: (Each undeclared 
> identifier is reported only once
> ../../gcc-snapshot/gcc/ggc-zone.c:626: error: for each function it 
> appears in.)
> ../../gcc-snapshot/gcc/ggc-zone.c:664: error: structure has no member 
> named `page_groups'
> ../../gcc-snapshot/gcc/ggc-zone.c:669: error: structure has no member 
> named `bytes_mapped'
> ../../gcc-snapshot/gcc/ggc-zone.c:674: error: structure has no member 
> named `free_pages'
>
> Grepping for entry_size, shows that it is never declared within 
> ggc-zone.c but it is within a highly similar block in ggc-page.c.


> Likewise for the structure G which in ggc-zone.c doesn't have 
> page_groups, bytes_mapped, nor free_pages as members, but they are 
> present in ggc-page.c
>
> Copy and paste errors?
Yeha.

That, and I have no easy way of testing the page_groups and friends 
stuff.

I'll probably just remove it for now, and require mmap.