This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: enable Ada test suite


On Mon, 27 Oct 2003, Arnaud Charlet wrote:

> I've also added a file gcc/testsuite/README.ada explaining the contents and
> basics of how the test suite works.

Please use doc/sourcebuild.texi to document the testsuite rather than
miscellaneous text files that aren't integrated into the rest of the
documentation.

> + ACATSDIR = $(TESTSUITEDIR)/ada/acats
> + 
> + check-gnat:
> + 	test -d $(ACATSDIR) || mkdir -p $(ACATSDIR)
> + 	testdir=`cd ${srcdir}/${ACATSDIR}; ${PWD_COMMAND}`; \
> + 	export testdir; cd $(ACATSDIR); $${testdir}/run_acats $(CHAPTERS)
> + 
> + .PHONY: check-gnat

Please put this in ada/Make-lang.in.  Something should be done at some 
point so that details of the individual languages using the shared 
testsuite rule go in their own Make-lang.in files rather than the 
individual front ends needing to be mentioned in gcc/Makefile.in; where a 
language has its own different testsuite rules, they shouldn't need to go 
in gcc/Makefile.in at all.

-- 
Joseph S. Myers
jsm@polyomino.org.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]