Re: Question on -Werror usage in Makefiles...

[Andreas Jaeger <aj at suse dot de>]

"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:

>  > From: Andreas Jaeger <aj@suse.de>
>  > [...]
>  > Do you have a patch?  In that case I would suggest that some of us
>  > apply it locally and try to kill those warnings that remain - and
>  > let's then decide whether it's ok to add it per default.
>  > 
>  > Andreas
>
>
> Untested, but this should work:
> [...]

It does indeed, now it really fails to bootstrap for:

/cvs/gcc/gcc/crtstuff.c: In function `__do_global_dtors_aux':

/cvs/gcc/gcc/crtstuff.c:282: warning: passing arg 1 of `__deregister_frame_info' discards qualifiers from pointer target type
/cvs/gcc/gcc/crtstuff.c: In function `frame_dummy':

/cvs/gcc/gcc/crtstuff.c:310: warning: passing arg 1 of `__register_frame_info' discards qualifiers from pointer target type
make[2]: *** [crtbeginT.o] Error 1

Is the following the right fix?   

I'm bootstrapping/regtesting on x86_64-linux-gnu now,

Andreas

2003-10-26  Andreas Jaeger  <aj@suse.de>

	* crtstuff.c (frame_dummy): Cast __EH_FRAME_BEGIN__ properly.
	(__do_global_dtors_aux): Likewise.

============================================================
Index: gcc/crtstuff.c
--- gcc/crtstuff.c	7 Jun 2003 17:30:32 -0000	1.62
+++ gcc/crtstuff.c	26 Oct 2003 16:36:40 -0000
@@ -276,10 +276,10 @@ __do_global_dtors_aux (void)
   /* If we used the new __register_frame_info_bases interface,
      make sure that we deregister from the same place.  */
   if (__deregister_frame_info_bases)
-    __deregister_frame_info_bases (__EH_FRAME_BEGIN__);
+    __deregister_frame_info_bases ((void *)__EH_FRAME_BEGIN__);
 #else
   if (__deregister_frame_info)
-    __deregister_frame_info (__EH_FRAME_BEGIN__);
+    __deregister_frame_info ((void *)__EH_FRAME_BEGIN__);
 #endif
 #endif
 
@@ -304,10 +304,10 @@ frame_dummy (void)
   tbase = 0;
   CRT_GET_RFIB_DATA (dbase);
   if (__register_frame_info_bases)
-    __register_frame_info_bases (__EH_FRAME_BEGIN__, &object, tbase, dbase);
+    __register_frame_info_bases ((void *)__EH_FRAME_BEGIN__, &object, tbase, dbase);
 #else
   if (__register_frame_info)
-    __register_frame_info (__EH_FRAME_BEGIN__, &object);
+    __register_frame_info ((void *)__EH_FRAME_BEGIN__, &object);
 #endif /* CRT_GET_RFIB_DATA */
 #endif /* USE_EH_FRAME_REGISTRY */
 #ifdef JCR_SECTION_NAME

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature