This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Ada fixes for mingw32- adaint.c (6/6)


 --- Arnaud Charlet <charlet@ACT-Europe.FR> wrote: > > All __attribute__((unused)) does is turn
off the warnings -- note the
> > 'possibly' in excerpt from gcc.info. 
> 
> This kind of attribute also act as documentation, and in this case, this
> would be a partly misleading documentation.
> 
> Instead, I'd suggest declaring the function separately for Windows,
> and not declaring any parameter.
> 
These are global functions.  Do you really want different interfaces for
different targets? No, I won't change the signatures.
 
The #ifdef TARGET stuff is messy enough already. Adding more to
the implementation will make it even harder to maintain.  The use of
__attribute__((unused)) documents that on some targets the argumnets
are unused.  But OK, I'll see what I can do without making an even bigger 
mess for the person who tries to clean up the unused warnings for, say, vxworks. 

Danny

> Arno 

http://personals.yahoo.com.au - Yahoo! Personals
New people, new possibilities. FREE for a limited time.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]