This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed fixes

> Jan Hubicka <> writes:
> >> That wasn't what I was asking.  Perhaps I am being exceptionally dense
> >> today, but I do not see how your patch causes -Werror not to be
> >> applied to stagefeedback.  As I said, it looks like it rearranges a
> >> few makefile variables, with no net effect.
> >
> > Originally the -Werror got into STAGE2_FLAGS, while I rearange
> > it to go throught STAGE*_FLAGS_TO_PASS and skip it in
> I still don't see it.  The -Werror was here:
> STRICT2_WARN = -pedantic -Wno-long-long @WERROR@
> you took it out of there, but then you put it right back:
> Explain to me how that makes it not show up in stagefeedback.

@WERROR@ is configure variable, so STRICT2_WARN ends up -pedantic
-Wno-long-long -Werror all the time, while $(WERROR) is make's variable
I set by hand only for submakes depending on the bootstrap stage in the
same way we do for CFLAGS and others.

In general stagefeedback needs all warnings as stage2+, but it needs not
-Werror, so I split up variables controling these.
Perhaps there is easier to understand way to reach this, but I can't see
it right now :(

> zw

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]