This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add various VxWorks target configs (1/3)


Mark Mitchell <mark@codesourcery.com> writes:

>> +#undef  TARGET_VERSION
>> +#define TARGET_VERSION fprintf (stderr, " (80586, VxWorks syntax)");
>
> This is a really weird convention; there's no special "VxWorks syntax"
> for assembly files or anything.  But, it does seem to be used throughout
> the i386/*.h files, so I guess that's OK.

TARGET_VERSION is entirely redundant with the TARGET_NAME #define
passed to toplev.c.  IMHO it should be ripped out, and the places that
use TARGET_VERSION (collect2, mips-tdump, mips-tfile, protoize) should
use TARGET_NAME (which would have to be migrated to auto-host.h, but
that's fine, it would mean toplev.o wouldn't depend on the Makefile
anymore).

Not that any of this should hold up the patch.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]