This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa][RFC] An interface to fold(tree)


On Mon, Oct 20, 2003 at 09:08:50AM -0600, Roger Sayle wrote:
> 
> Good interfaces are created by design, not out of convenience.
> Your factoring of code seems to be driven more by the local variables
> that a live in the original function than by good design practices.
> 

Note that a part of these functions have to be declared as static and 
not visible in the final interface.  But anyway, ...

> I think everyone agrees that fold could be restructured, but now is not
> the time to do it, and this way is not the way to do it.  In the
> mean-time, there are plenty of bugs that need fixing on both mainline
> and tree-ssa that should have higher priority during the current stage
> of development.  The faster these issue get addressed, the earlier we
> can thaw for the much needed clean-up work.
> 

Sorry for the noise, I will wait until someone more competent will have 
the time and the will to do the clean-up.

Sebastian.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]