This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed fixes
Jan Hubicka <jh@suse.cz> writes:
>> Jan Hubicka <jh@suse.cz> writes:
>>
>> > Hi,
>> > here are few fixes waiting for review I would love to see in mainline :)
>> >
>> > Fix for make profilebootstrap failure
>> > http://gcc.gnu.org/ml/gcc-patches/2003-09/msg02061.html
>>
>> I do not understand why this fixes the problem. It looks like you
>> just rearranged the makefile variables in a way that ought to have
>> no effect. Could you explain why this fixes it?
>
> It is important to not pass -Werror in stagefeedback as we produce
> warning about missing profile for each file that contains no function
> linked into final executable and we compile few of these depending on
> configuration.
That wasn't what I was asking. Perhaps I am being exceptionally dense
today, but I do not see how your patch causes -Werror not to be
applied to stagefeedback. As I said, it looks like it rearranges a
few makefile variables, with no net effect.
zw